Update hexSlice to use TypedArrays and TextDecoder for large speed gains#367
Open
jawj wants to merge 2 commits intofeross:masterfrom
Open
Update hexSlice to use TypedArrays and TextDecoder for large speed gains#367jawj wants to merge 2 commits intofeross:masterfrom
hexSlice to use TypedArrays and TextDecoder for large speed gains#367jawj wants to merge 2 commits intofeross:masterfrom
Conversation
Author
|
@dcousens Any chance of merging this in the near future? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #364 and #366, this patch switches the
hexSliceimplementation to use TypedArrays and TextDecoder. It also adds a performance benchmark fortoString('hex').In Node on an M3 Pro MacBook, the benchmark shows a 5x speed-up on a 4096-byte buffer, achieving 75% of the speed of the native method. The speed-up is generally larger as the buffer size increases.
Before:
After: